From: Keir Fraser Date: Mon, 3 Nov 2008 10:23:09 +0000 (+0000) Subject: xend: ioport & irq persistence thru reboot X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~14054^2~4 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https://%22%22/%22http:/www.example.com/cgi/%22https:/%22%22?a=commitdiff_plain;h=9cec91aba58722d189ef7f5c7257aed5fc072e8c;p=xen.git xend: ioport & irq persistence thru reboot When a domU is configured for a serial port as documented at: http://wiki.xensource.com/xenwiki/InstallationNotes the VM does see the serial port, however when dom0 is rebooted and the VM started it no longer has access to the serial port. xm list -l no longer shows the ioports or irq attributes Attached patch adds implementation of getDeviceConfiguration(), returns details dict and implements waitForDevice() to irqif.py and iopif.py. Also added preprocess_irq() to create.py. Signed-off-by: Pat Campbell --- diff --git a/tools/python/xen/xend/server/iopif.py b/tools/python/xen/xend/server/iopif.py index 3b1a263736..4c6e612465 100644 --- a/tools/python/xen/xend/server/iopif.py +++ b/tools/python/xen/xend/server/iopif.py @@ -45,9 +45,22 @@ def parse_ioport(val): class IOPortsController(DevController): + valid_cfg = ['to', 'from', 'uuid'] + def __init__(self, vm): DevController.__init__(self, vm) + def getDeviceConfiguration(self, devid, transaction = None): + result = DevController.getDeviceConfiguration(self, devid, transaction) + if transaction is None: + devinfo = self.readBackend(devid, *self.valid_cfg) + else: + devinfo = self.readBackendTxn(transaction, devid, *self.valid_cfg) + config = dict(zip(self.valid_cfg, devinfo)) + config = dict([(key, val) for key, val in config.items() + if val != None]) + return config + def getDeviceDetails(self, config): """@see DevController.getDeviceDetails""" @@ -81,4 +94,9 @@ class IOPortsController(DevController): 'ioports: Failed to configure legacy i/o range: %s - %s' % (io_from, io_to)) - return (None, {}, {}) + back = dict([(k, config[k]) for k in self.valid_cfg if k in config]) + return (self.allocateDeviceID(), back, {}) + + def waitForDevice(self, devid): + # don't wait for hotplug + return diff --git a/tools/python/xen/xend/server/irqif.py b/tools/python/xen/xend/server/irqif.py index db4b1deedd..ae0b1ff4b6 100644 --- a/tools/python/xen/xend/server/irqif.py +++ b/tools/python/xen/xend/server/irqif.py @@ -39,6 +39,18 @@ class IRQController(DevController): def __init__(self, vm): DevController.__init__(self, vm) + valid_cfg = ['irq', 'uuid'] + + def getDeviceConfiguration(self, devid, transaction = None): + result = DevController.getDeviceConfiguration(self, devid, transaction) + if transaction is None: + devinfo = self.readBackend(devid, *self.valid_cfg) + else: + devinfo = self.readBackendTxn(transaction, devid, *self.valid_cfg) + config = dict(zip(self.valid_cfg, devinfo)) + config = dict([(key, val) for key, val in config.items() + if val != None]) + return config def getDeviceDetails(self, config): """@see DevController.getDeviceDetails""" @@ -75,4 +87,9 @@ class IRQController(DevController): if rc < 0: raise VmError( 'irq: Failed to map irq %x' % (pirq)) - return (None, {}, {}) + back = dict([(k, config[k]) for k in self.valid_cfg if k in config]) + return (self.allocateDeviceID(), back, {}) + + def waitForDevice(self, devid): + # don't wait for hotplug + return diff --git a/tools/python/xen/xm/create.py b/tools/python/xen/xm/create.py index f270da8927..eb8f3e237c 100644 --- a/tools/python/xen/xm/create.py +++ b/tools/python/xen/xm/create.py @@ -1036,6 +1036,14 @@ def preprocess_ioports(vals): ioports.append(hexd) vals.ioports = ioports +def preprocess_irq(vals): + if not vals.irq: return + irq = [] + for v in vals.irq: + d = repr(v) + irq.append(d) + vals.irq = irq + def preprocess_vtpm(vals): if not vals.vtpm: return vtpms = [] @@ -1134,6 +1142,7 @@ def preprocess(vals): preprocess_vscsi(vals) preprocess_ioports(vals) preprocess_ip(vals) + preprocess_irq(vals) preprocess_nfs(vals) preprocess_vtpm(vals) preprocess_access_control(vals)